Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(google-auth): use workload identity federation instead of json #10342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(google-auth): use workload identity federation instead of json #10342

wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Oct 21, 2024

No description provided.

@cpcloud cpcloud added this to the 10.0 milestone Oct 21, 2024
@cpcloud cpcloud added ci Continuous Integration issues or PRs bigquery The BigQuery backend labels Oct 21, 2024
@cpcloud cpcloud requested a review from tswast October 21, 2024 13:49
tswast
tswast reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Still working on getting approvals to enable this in our ibis-gbq test project.

@cpcloud
Copy link
Member Author

cpcloud commented Nov 12, 2024

@tswast Should we just give this a go and merge it?

@cpcloud cpcloud force-pushed the google-cloud-workload-id-federation branch from ba0cee5 to 620bd00 Compare November 12, 2024 10:37
@tswast
Copy link
Collaborator

tswast commented Nov 12, 2024 •
edited
Loading

Sorry, I misspoke at PyData NYC. Looks like I'm still waiting for approval on one more internal change (issue 375475414 for Googlers' reference) before this can work.

@cpcloud
Copy link
Member Author

cpcloud commented Dec 17, 2024

@tswast Any updates here?

@tswast
Copy link
Collaborator

tswast commented Dec 17, 2024

Thanks for the reminder. I'm still waiting on a thumbs up from our security team. I think I went through the right process, but it's been stuck on the last LGTM for a couple months now. 😭 I'll ping them again today. Maybe I can get another reviewer assigned?

@cpcloud cpcloud removed this from the 10.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bigquery The BigQuery backend ci Continuous Integration issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @tswast