Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default find regexes #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zemja
Copy link
Contributor

@zemja zemja commented Nov 13, 2022

Fuck, sorry, I broke things yesterday with the Syncthing regex.emacs-conflict--get-normal-filename wouldn't return the file extension for files WITH an extension, but would work fine for files without.

This now works properly, I swear to God.

@ibizaman
Copy link
Owner

Hey no worries! At least half of the issue falls on me for not reviewing thoroughly. Regex are hard…

If you don’t mind I’ll merge your PR when I added some testing around it.

@zemja
Copy link
Contributor Author

zemja commented Nov 19, 2022

Hi, just to mention I broke this quite badly with my last PR (files with a . in the name don't work), so I'd encourage you to revert that last commit before you get around to reviewing this one. For the sake of everybody pulling this repo automatically in their init.el :)

@ibizaman
Copy link
Owner

@zemja that makes sense. I just did :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants