-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webapp-strategy.js): importing the SDK to typescript project error #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/ibm-cloud-security/appid-serversdk-nodejs into fix-error-importing-sdk-to-typescript-project-develop
…dk-to-typescript-project-develop fix(webapp-strategy.js): importing the SDK to typescript project error
abod-akhras
requested review from
dventurait,
ibm-app-id-o-fletch,
jay-mack and
vladimiratanasov
January 25, 2023 10:33
vladimiratanasov
approved these changes
Jan 25, 2023
dventurait
approved these changes
Jan 25, 2023
Alter samples and Lib
Update package version number
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to work with passport version 0.6.0
Removed the hardcoded
KeepSessionInfo: true
options in the SDK.Updated the sample applications to show how
KeepSessionInfo: true
can be passed in the SDK.Updated the Logout function in the sample applications
fixed the deprecated IAM token endpoint in the SDk.
Fix importing the SDK to typescript project error (Issue: Importing in a Typescript project #199)
BREAKING CHANGE: KeepSessionInfo should be passed like { keepSessionInfo: true }, please see new examples.
fix #274 & fix #287