Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp-strategy.js): importing the SDK to typescript project error #292

Merged
merged 13 commits into from
Jan 31, 2023

Conversation

abod-akhras
Copy link
Collaborator

@abod-akhras abod-akhras commented Jan 25, 2023

Updated to work with passport version 0.6.0

  • Removed the hardcoded KeepSessionInfo: true options in the SDK.

  • Updated the sample applications to show how KeepSessionInfo: true can be passed in the SDK.

  • Updated the Logout function in the sample applications

  • fixed the deprecated IAM token endpoint in the SDk.

  • Fix importing the SDK to typescript project error (Issue: Importing in a Typescript project #199)

BREAKING CHANGE: KeepSessionInfo should be passed like { keepSessionInfo: true }, please see new examples.

fix #274 & fix #287

@coveralls
Copy link

coveralls commented Jan 25, 2023

Coverage Status

Coverage: 95.34% (-0.009%) from 95.349% when pulling 5d12888 on development into 82e30ed on master.

@abod-akhras abod-akhras merged commit dcf3086 into master Jan 31, 2023
@github-actions
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebAppStrategy.logout doesn't work after update to passport v0.6.0 Refactor for KeepSession
5 participants