Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BanditScheduler: Add emitter_pool and active attr; remove emitters attr #494

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

btjanaka
Copy link
Member

Description

Currently, the BanditScheduler has an emitters attr that returns the _active_arr variable. This does not make much sense since BanditScheduler does not have emitters as input, and _active_arr gives emitters a different meaning from the emitters attribute of Scheduler.

Thus, this PR removes the emitters attr and instead adds emitter_pool and active to indicate the pool of emitters in the scheduler and which ones are currently active, respectively.

TODO

  • Remove BanditScheduler.emitters
  • Add BanditScheduler.emitter_pool
  • Add BanditScheduler.active

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka
Copy link
Member Author

Will merge once #489 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant