rename test to columns_conditions, add note on overloading 'in' keyword

overloading 'in' is not possible as it always casts to bool
icyveins7 · Mar 19, 2024 · f249985 · f249985
1 parent 3947cfc
commit f249985
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/sew/condition.py b/sew/condition.py
@@ -235,3 +235,5 @@ def __le__(self, other: Condition) -> Condition:
 
         return Condition(condstr)
 
+    ##### NOTE: you cannot overload 'in' keyword, as __contains__ always casts the return to a bool
+
diff --git a/tests/columns.py → tests/columns_conditions.py b/tests/columns.py → tests/columns_conditions.py
@@ -139,4 +139,11 @@ def test_column_composite_comparisons_noncommutative(self):
             "col1 < 10 OR (col2 < 10 AND col3 < 10)"
         )
 
+        # Finally test a 4-way condition
+        comp = (cond1 | cond2) & (cond3 | "col4 < 100")
+        self.assertEqual(
+            str(comp),
+            "(col1 < 10 OR col2 < 10) AND (col3 < 10 OR col4 < 100)"
+        )
+
Original file line number	Diff line number	Diff line change
Expand Up		@@ -235,3 +235,5 @@ def __le__(self, other: Condition) -> Condition:

		return Condition(condstr)

		##### NOTE: you cannot overload 'in' keyword, as __contains__ always casts the return to a bool