Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the manual option for library handler to generate the correct dependency latex file #2257

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Feb 5, 2024


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#1806

What are the significant changes in functionality due to this change request?

Recent changes in library update to pin liblapack version broke make of SDD manual. This PR will fix this minor issue.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05
Copy link
Collaborator Author

wangcj05 commented Feb 5, 2024

@joshua-cogliati-inl Minor issue with SDD document, could you take a look?

Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and I approve.

@moosebuild
Copy link

Job Test qsubs sawtooth on 87d5bbf : invalidated by @joshua-cogliati-inl

Failed Diff tests/cluster_tests/AdaptiveSobol/test_parallel_adaptive_sobol

@joshua-cogliati-inl
Copy link
Contributor

Results from building the documents:

RAVENv2.3-233-g8e391e2fb
version.tex is not found, generate new one
Building in user_manual...
...Successfully made docs in user_manual
Building in user_guide...
...Successfully made docs in user_guide
Building in theory_manual...
...Successfully made docs in theory_manual
Building in tests...
...Successfully made docs in tests
Building in plugins_manual...
...Successfully made docs in plugins_manual
CONDA
raven_libraries       *  /home/cogljj/.conda/envs/raven_libraries
RAVENv2.3-233-g8e391e2fb
1,3c1
< RAVENv2.3-233-g8e391e2fb
< \\
< 80ad534d8f4ea50c4512891904437124e712f564 Congjian Wang\\Thu, 15 Sep 2022 09:05:10 -0600
---
> bfb53aa0002077c703251cd952a2ee2c453fcdf6 Congjian Wang - INL Wed, 24 Jan 2024 15:51:10 -0700
Building in sdd...
...Successfully made docs in sdd
Building in rtr...
...Successfully made docs in rtr
Building in srs...
...Successfully made docs in srs
Building in srs_rtr_combined...
...Successfully made docs in srs_rtr_combined

Exit status 0
Ran ./doc/make_docs.sh

@joshua-cogliati-inl joshua-cogliati-inl merged commit 9d8eae4 into devel Feb 6, 2024
12 checks passed
@joshua-cogliati-inl joshua-cogliati-inl deleted the wangc/issue_sdd branch February 6, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants