Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StateInfoPubSignals interface #89

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

x1m3
Copy link
Contributor

@x1m3 x1m3 commented Oct 30, 2024

No description provided.

@x1m3 x1m3 requested review from olomix, demonsh and vmidyllic October 30, 2024 15:35
vmidyllic
vmidyllic previously approved these changes Nov 1, 2024
olomix
olomix previously approved these changes Nov 1, 2024
circuits.go Outdated
}

// States information
type States struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@x1m3 @vmidyllic
Why it is plural States and Gists?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, it should be State/ Gist or just anonymus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. Changed

@x1m3 x1m3 dismissed stale reviews from olomix and vmidyllic via 2c17268 November 5, 2024 09:12
@x1m3 x1m3 requested review from demonsh, olomix and vmidyllic November 5, 2024 09:13
@demonsh demonsh merged commit 2bd2c4b into main Dec 18, 2024
4 checks passed
@demonsh demonsh deleted the PID-2502-add-oracles-functionality-to-go-circuits branch December 18, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants