Add verifier #12
Merged
Add verifier #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2024 23:37
olomix
approved these changes
Feb 6, 2024
| #endif | ||
|
|
||
| //Error codes returned by the functions. | ||
| #define VERIFIER_VALID_PROOF 0x0 |
There was a problem hiding this comment.
As it is a C header without C++ namespacing, I would add GROTH16_ prefix to these constant. But as counterpart PROOF_ error codes do not have this prefix, may be such naming is OK too 🤷
olomix
requested changes
Feb 6, 2024
There was a problem hiding this comment.
It doesn't work properly.
We have a test case where we generate proof using cmd prover, then validate this proof with snarkjs.
rapidsnark/.github/workflows/build.yml
Line 139 in 5af1b04
I've also generated a proof on my laptop. Tried to validate it at got the OK result
package_macos_arm64/bin/verifier proof.json public.json testdata/verification_key.json
Result: Valid proof
Then I modified the public.json file, rerun the command
$ package_macos_arm64/bin/verifier proof.json public.json testdata/verification_key.json
Result: Valid proof
and still got an OK result. While the snarkjs is returning error on modified public.json.
olomix
approved these changes
Feb 20, 2024
OBrezhniev
approved these changes
Feb 22, 2024
…uts. Add unit tests for functions groth16_public_size_for_zkey_file and groth16_public_size_for_zkey_buf. Also enable ctest functionality that would enable us to write unit tests for different parts and run them as part for the cmake pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.