Replace usage of 'abs()' by 'fabs()'

'abs()' is only defined for int's in the standard, but on some platforms works for doubles too
idiap · Dec 13, 2024 · 4ed5f9f · 4ed5f9f
1 parent ac0b127
commit 4ed5f9f
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 14 deletions.
diff --git a/src/gafro/algebra/Multivector.hxx b/src/gafro/algebra/Multivector.hxx
@@ -332,7 +332,7 @@ namespace gafro
     template <class T, int... index>
     T Algebra<M>::Multivector<T, index...>::norm() const
     {
-        return sqrt(abs(squaredNorm()));
+        return sqrt(fabs(squaredNorm()));
     }
 
     template <class M>
@@ -348,7 +348,7 @@ namespace gafro
     {
         T squared_norm = squaredNorm();
 
-        return squared_norm > 0 ? sqrt(squared_norm) : -sqrt(abs(squared_norm));
+        return squared_norm > 0 ? sqrt(squared_norm) : -sqrt(fabs(squared_norm));
     }
 
     template <class M>

diff --git a/src/gafro/algebra/cga/Circle.hxx b/src/gafro/algebra/cga/Circle.hxx
@@ -49,7 +49,7 @@ namespace gafro
     {
         auto mv = ((*this) * (Scalar<T>(T(-1.0)) * ((*this).dual() | Ei<T>(T(1.0))).evaluate().inverse())).evaluate();
 
-        return sqrt(abs((mv * mv).template get<blades::scalar>()));
+        return sqrt(fabs((mv * mv).template get<blades::scalar>()));
     }
 
     template <typename T>

diff --git a/src/gafro/algebra/cga/ConformalGeometricAlgebra.hpp b/src/gafro/algebra/cga/ConformalGeometricAlgebra.hpp
@@ -50,7 +50,7 @@ namespace gafro
 
         for (unsigned int k = 0; k < mv.vector().rows(); ++k)
         {
-            if (abs(mv.vector().coeff(k, 0)) < 1e-10)
+            if (fabs(mv.vector().coeff(k, 0)) < 1e-10)
             {
                 continue;
             }
@@ -59,7 +59,7 @@ namespace gafro
             {
                 ostream << (mv.vector().coeff(k, 0) >= 0 ? " + " : " - ");
 
-                ostream << abs(mv.vector().coeff(k, 0));
+                ostream << fabs(mv.vector().coeff(k, 0));
             }
             else
             {

diff --git a/src/gafro/algebra/cga/MotorLogarithm.hpp b/src/gafro/algebra/cga/MotorLogarithm.hpp
@@ -42,23 +42,23 @@ namespace gafro
             switch (blade)
             {
             case blades::e23:
-                if (TypeTraits<T>::greaterEqual(abs(motor.template get<blades::scalar>()), TypeTraits<T>::Value(1.0 - 1e-10)))
+                if (TypeTraits<T>::greaterEqual(fabs(motor.template get<blades::scalar>()), TypeTraits<T>::Value(1.0 - 1e-10)))
                 {
                     return TypeTraits<T>::Zero();
                 }
 
                 return motor.template get<blades::e23>() * TypeTraits<T>::Value(-2.0) * acos(motor.template get<blades::scalar>()) /
                        (sin(acos(motor.template get<blades::scalar>())) + TypeTraits<T>::Value(1e-10));
             case blades::e13:
-                if (TypeTraits<T>::greaterEqual(abs(motor.template get<blades::scalar>()), TypeTraits<T>::Value(1.0 - 1e-10)))
+                if (TypeTraits<T>::greaterEqual(fabs(motor.template get<blades::scalar>()), TypeTraits<T>::Value(1.0 - 1e-10)))
                 {
                     return TypeTraits<T>::Zero();
                 }
 
                 return motor.template get<blades::e13>() * TypeTraits<T>::Value(-2.0) * acos(motor.template get<blades::scalar>()) /
                        (sin(acos(motor.template get<blades::scalar>())) + TypeTraits<T>::Value(1e-10));
             case blades::e12:
-                if (TypeTraits<T>::greaterEqual(abs(motor.template get<blades::scalar>()), TypeTraits<T>::Value(1.0 - 1e-10)))
+                if (TypeTraits<T>::greaterEqual(fabs(motor.template get<blades::scalar>()), TypeTraits<T>::Value(1.0 - 1e-10)))
                 {
                     return TypeTraits<T>::Zero();
                 }

diff --git a/src/gafro/algebra/cga/Rotor.hxx b/src/gafro/algebra/cga/Rotor.hxx
@@ -62,7 +62,7 @@ namespace gafro
     {
         T acos = std::acos(scalar());
 
-        if (abs(acos) < 1e-6)
+        if (fabs(acos) < 1e-6)
         {
             return Rotor<T>::Generator({ e12(), e13(), e23() });
         }

diff --git a/src/gafro/algebra/cga/Sphere.hxx b/src/gafro/algebra/cga/Sphere.hxx
@@ -48,7 +48,7 @@ namespace gafro
     template <typename T>
     T Sphere<T>::getRadius() const
     {
-        return sqrt(abs(((*this) * Scalar<T>(-1.0 / (this->dual() | Ei<T>(1.0)).template get<blades::scalar>())).evaluate().squaredNorm()));
+        return sqrt(fabs(((*this) * Scalar<T>(-1.0 / (this->dual() | Ei<T>(1.0)).template get<blades::scalar>())).evaluate().squaredNorm()));
     }
 
     template <typename T>

diff --git a/src/gafro/algebra/dqa/DualQuaternionAlgebra.hpp b/src/gafro/algebra/dqa/DualQuaternionAlgebra.hpp
@@ -86,7 +86,7 @@ std::ostream &operator<<(std::ostream &ostream, const gafro::dqa::Multivector<do
 
     for (unsigned int k = 0; k < dq.vector().rows(); ++k)
     {
-        if (abs(dq.vector().coeff(k, 0)) < 1e-10)
+        if (fabs(dq.vector().coeff(k, 0)) < 1e-10)
         {
             continue;
         }
@@ -95,7 +95,7 @@ std::ostream &operator<<(std::ostream &ostream, const gafro::dqa::Multivector<do
         {
             ostream << (dq.vector().coeff(k, 0) >= 0 ? " + " : " - ");
 
-            ostream << abs(dq.vector().coeff(k, 0));
+            ostream << fabs(dq.vector().coeff(k, 0));
         }
         else
         {

diff --git a/src/gafro/algebra/pga/ProjectiveGeometricAlgebra.hpp b/src/gafro/algebra/pga/ProjectiveGeometricAlgebra.hpp
@@ -79,7 +79,7 @@ std::ostream &operator<<(std::ostream &ostream, const gafro::pga::Multivector<do
 
     for (unsigned int k = 0; k < dq.vector().rows(); ++k)
     {
-        if (abs(dq.vector().coeff(k, 0)) < 1e-10)
+        if (fabs(dq.vector().coeff(k, 0)) < 1e-10)
         {
             continue;
         }
@@ -88,7 +88,7 @@ std::ostream &operator<<(std::ostream &ostream, const gafro::pga::Multivector<do
         {
             ostream << (dq.vector().coeff(k, 0) >= 0 ? " + " : " - ");
 
-            ostream << abs(dq.vector().coeff(k, 0));
+            ostream << fabs(dq.vector().coeff(k, 0));
         }
         else
         {