Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss issued and presented forms of JPTs #135

Merged

Conversation

selfissued
Copy link
Collaborator

Fixes #96

@selfissued selfissued requested review from dwaite and quartzjer August 7, 2024 01:47
@selfissued
Copy link
Collaborator Author

Fixes #99

@selfissued selfissued changed the title Enhance JPT payload description Discuss issued and presented forms of JPTs Aug 7, 2024
draft-ietf-jose-json-proof-token.md Outdated Show resolved Hide resolved
Comment on lines 143 to 147
## Undisclosed

The placeholder indicating that a payload was not disclosed is represented as
a `null` value for the JWP JSON Serialization
or the empty string value for the JWP Compact Serialization.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend we leave this to the core JWP spec. I'm specifically trying to consolidate special cases like this under the serialization rules.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the text to reference the representation in JWP rather than repeating it.

@dwaite dwaite merged commit 2b82c80 into ietf-wg-jose:main Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate promoting parts of section 7 of JPT to the JWP spec
2 participants