Allow data reduction for data with no b/offs using modified pattern removal. Restore ability to generate wavelength solutions from ThAr arc lamp. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 25, 2024 19:13
|
ThAr lamp distortion correction is not working properly and will need fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request features two major updates to the IGRINS PLP. The ability to reduce data with no associated b exposures. This is done by modifying the pattern removal. Note that the pattern removal is not as good with no b exposures, and it is recommended you include b (or off) nod exposures when observing. This is mostly for lab data.
I also restored the ability of the IGRINS PLP to calculate wavelength solutions from ThAr arc lamp calibration data. This was a feature in the PLP v2, and the ThAr lamp has not been installed in IGRINS for some time. This ability is mostly meant for old or lab data.