fix: deletedAt not set for offline assets during 1.116.0 migration #13086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
approved these changes
Oct 1, 2024
zackpollard
force-pushed
the
fix/external-library-offline-deletedat-migration
branch
from
49b9cb3 to
327d65b
Compare
Fixed this with a change in the query. |
zackpollard
deleted the
fix/external-library-offline-deletedat-migration
branch
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.116.0 we now assume deletedAt is set for offline assets, which makes them show in trash and get hidden in other screens. This PR will add a migration to set deletedAt for all offline files at the time it runs.