feat(server): better mount checks #13092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
jrasm91
force-pushed
the
feat/better-mount-checks
branch
from
4f37297 to
7dffc95
Compare
bo0tzz
approved these changes
Oct 1, 2024
Comment on lines
+41
to
+47
| ### Ignoring the checks | ||
|
|
||
| The checks are designed to catch common problems that we have seen users have in the past, but if you want to disable them you can set the following environment variable: | ||
|
|
||
| ``` | ||
| IMMICH_IGNORE_MOUNT_CHECK_ERRORS=true | ||
| ``` |
There was a problem hiding this comment.
Do we want to add a disclaimer here along the lines of "if you've used this env var then unfortunately we can't help you with mountpoint issues"?
There was a problem hiding this comment.
I think it is implied that when you disable default protections you are assuming the associated risk, but I can add a explicit note if you think that would be beneficial.
|
Can we add an entry to the env vars page for this? |
Sure. |
danieldietzler
approved these changes
Oct 1, 2024
jrasm91
force-pushed
the
feat/better-mount-checks
branch
from
7dffc95 to
eace7ed
Compare
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.immichalready exists, but mount checks aren't enabled