Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(server): config file env #13100

Merged
merged 1 commit into from
Oct 1, 2024
Merged

refactor(server): config file env #13100

merged 1 commit into from
Oct 1, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Oct 1, 2024

Proxy requests to access IMMICH_CONFIG_FILE through IConfigRepository.getEnv() and simplify associated tests.

danieldietzler
danieldietzler approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jrasm91 jrasm91 merged commit 6343752 into main Oct 1, 2024
36 checks passed
@jrasm91 jrasm91 deleted the refactor/config-file-env branch October 1, 2024 20:03
yosit pushed a commit to yosit/immich that referenced this pull request Oct 3, 2024
@jrasm91
refactor(server): config file env (immich-app#13100)
7fe6298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
changelog:skip 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrasm91 @danieldietzler