feat: Add support for preloading textual clip model without visual model #13368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
1-tempest
changed the title
1-tempest
changed the title
|
How does this PR relate to #12729? |
|
It's similar for sure. I only have about 60 IOPS available on my machine due to my drives (smr unfortunately), so I'd be a little concerned about increasing IO on user connect. Ideally I leave all IO for populating thumbs. I'd need to try that PR to know if it makes any noticeable impact on user connect in my case (I assume I'd be worst case scenario), if the impact is marginal then my approach is indeed unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preloading the textual clip model is required for quick smart searches.
I'd like to suggest having an ability to load the textual model without the dependency of the visual model to preserve system ram.