Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Adds toggle to disable sorting of faces #14830

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

Lukasdotcom
Copy link
Contributor

@Lukasdotcom Lukasdotcom commented Dec 20, 2024

Adds a way to disable sorting of faces by similarity on merge screen and the detailed face view (#14635) below search bar. Keeps similarity sorting enabled as the default.

Fixes #14762
FIxes #14843

@Lukasdotcom Lukasdotcom changed the title feat(web): Adds setting to disable sorting of face in merge screen feat(web): Adds setting to disable sorting of faces in merge screen Dec 20, 2024
@alextran1502
Copy link
Contributor

I think a better place for this is a toggle in the merge face interface itself

@Lukasdotcom
Copy link
Contributor Author

@alextran1502 I was just about to ask if that would be a better choice.

@alextran1502
Copy link
Contributor

Haha, like minds

@Lukasdotcom Lukasdotcom changed the title feat(web): Adds setting to disable sorting of faces in merge screen feat(web): Adds toggle to disable sorting of faces in merge screen Dec 20, 2024
@welpher
Copy link

welpher commented Dec 21, 2024

I think a better place for this is a toggle in the merge face interface itself

Not only in the merge face page, the detail page named face should display first

@Lukasdotcom
Copy link
Contributor Author

You mean this screen right?
image
I added it to that one, but I probably should have updated the description of the pull request.

@Lukasdotcom Lukasdotcom changed the title feat(web): Adds toggle to disable sorting of faces in merge screen feat(web): Adds toggle to disable sorting of faces Dec 21, 2024
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I cleaned up the logic and the UI to make the components fit in the context. I also set the sort to false by default because it causes an error that if there are no similar faces found, then no faces would be rendered

image

@alextran1502 alextran1502 enabled auto-merge (squash) December 21, 2024 16:48
@alextran1502 alextran1502 merged commit d5906c2 into immich-app:main Dec 21, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge sort by similarity is often empty
3 participants