General update

[SolidifiedRay]

Make some changes due to the latest frontend and Python 3.

See commit messages for the details.

[lukpueh]

Will this still work on Python 2? If not, we should mention it maybe in the commit message and also change the requirements section in the README.md.

[lukpueh]

@SolidifiedRay, would you mind taking a look at #39, #40, #41, #42 and see if updating those breaks anything?

[SolidifiedRay]

Will this still work on Python 2? If not, we should mention it maybe in the commit message and also change the requirements section in the README.md.

This still work on Python 2. I will take a look at other updates soon.

[SolidifiedRay]

@SolidifiedRay, would you mind taking a look at #39, #40, #41, #42 and see if updating those breaks anything?

They look good to me. I ran them locally and did some quick tests. No errors show up. @lukpueh

[lukpueh]

They look good to me. I ran them locally and did some quick tests. No errors show up. @lukpueh

Thanks for checking. Let's merge them in then.

[SolidifiedRay]

I go back to have another look at Request.is_xhr and find Werkzeug(WSGI) repo also has an issue for this.
According to issue #1077 in werkzeug repo, werkzeug removed Request.is_xhr as it is not reliable. Since Flask depends on the Werkzeug toolkit, Request.is_xhr is also no longer supported in Flask.
Here is a quote from issue # 1077:

The Request.is_xhr was introduced 9 years ago. It detects from a header called X-Requested-With which is added by JavaScript libraries.

The world is different now. jQuery is losing its popularity; and fetch is shining. Many would choose to use fetch instead of XMLHttpRequest nowadays. Popular ajax libraries such as axios has no built-in X-Requested-With header.

X-Requested-With is not a part of any spec, it is not reliable. It is the time to deprecate it.

Maybe we should also remove the check for XMLHttpRequest? What do you think? @lukpueh

[adityasaky]

LGTM, thanks @SolidifiedRay!

[adityasaky]

LGTM, thanks @SolidifiedRay!

[lukpueh]

IIUC you are re-implementing the check that the deprecated request.is_xhr used to perform, right?

Did you have a chance to check if the jquery ajax call we use still sets that header, so that our ajax_flash_messages hook still works?

[SolidifiedRay]

Thanks a ton for the review @lukpueh !!

I checked the ajax_flash_messages hook and unfortunately something is not right.
For example, when I upload the functionary's public key in the functionaries page, the flash messages show up only after I manually refresh the page. When I try to remove the functionary that already has a pubkey, I also have to refresh the page to see the change and the flash message. I am not sure if there is something wrong with the ajax call or the ajax_flash_messages hook, but I will try to find up why this happened.

[SolidifiedRay]

As a follow-up, I will work on rule generation first, which seems to have a higher priority than this problem.

[SolidifiedRay]

I found ajax_flash_messages working again.

I check the jquery ajax call with the browser's network console, and it does include the X-Requested-With header with the value XMLHttpRequest. So I believe there is no problem with the code here. I doubt that it failed previously is because my Virtual Machine didn't run the WSGI server correctly.

[lukpueh]

I'll merge then. Thanks for the updates!