-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rendergraph #533
Draft
IAmNotHanni
wants to merge
179
commits into
main
Choose a base branch
from
hanni/rendergraph2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor rendergraph #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAmNotHanni
added
cat:refactor
refactor/clean up/simplifications/etc.
feat:rendering
rendering
labels
May 12, 2023
IAmNotHanni
force-pushed
the
hanni/rendergraph2
branch
from
May 13, 2023 00:14
8ac6aca
to
b6c790f
Compare
IAmNotHanni
force-pushed
the
hanni/rendergraph2
branch
6 times, most recently
from
May 18, 2023 12:23
dad7478
to
37a0506
Compare
IAmNotHanni
force-pushed
the
hanni/rendergraph2
branch
4 times, most recently
from
May 20, 2023 21:53
d23d14d
to
6afd9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat:refactor
refactor/clean up/simplifications/etc.
feat:rendering
rendering
prio:high
This has high priority.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this gets merged, we should release
v0.1-alpha.4
Major Changes
VkSampler
VkGraphicsPipeline
VkPipelineLayout
make_info.cpp
msaa_target.hpp
VK_API_VERSION_1_3
for Vulkan Memory AllocatorMinor Changes
.reset()
explicitely before smart pointer reassignment (this is redundant)Outlook (rendergraph3)
VkWriteDescriptorSet
updating mechanismVkRenderingAttachmentInfo
instead of doing it per-framecmd_buf.bind_descriptor_set
wrapper functionGraphicsPipelineBuilder
and ? (GraphicsPass
wrapper?)PipelineBarrierBatchBuilder
? (Real use might not be significant)