-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Submodule Issues and updated/added list_code_examples #5722
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the list code examples. We should truncate/condense them like we discussed--sorry if that wasn't clear. Otherwise, they'll be too long in the section list page.
Suggestions:
- focus on the python example so we can merge your fix for the page
- if you
git checkout
a feature branch for an issue, then you can add commits to that same branch to update the PR instead of creating a new PR. See https://www.atlassian.com/git/tutorials/comparing-workflows/feature-branch-workflow - add the condensed examples for other languages later in a new feature branch and PR.
``` | ||
<!--pytest-codeblocks:cont--> | ||
|
||
--> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment close tag at 190 needs to move up to close the opening at 174.
Closes #
Describe your proposed changes here.
submoduel removal
updates based on comment recommendations on prior pull request
updates to javascript.md list_code_example
added list_code_example to java.md
added list_code_example to go.md
added list_code_example to chsarp.md
Signed the InfluxData CLA
(if necessary)
Rebased/mergeable