Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Submodule Issues and updated/added list_code_examples #5722

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MeelahMe
Copy link

@MeelahMe MeelahMe commented Dec 24, 2024

Closes #

Describe your proposed changes here.

  • submoduel removal

  • updates based on comment recommendations on prior pull request

  • updates to javascript.md list_code_example

  • added list_code_example to java.md

  • added list_code_example to go.md

  • added list_code_example to chsarp.md

  • Signed the InfluxData CLA
    (if necessary)

  • Rebased/mergeable

@MeelahMe MeelahMe requested a review from jstirnaman December 27, 2024 01:47
@MeelahMe MeelahMe changed the title Fix Submodule Issues and Improve Python Code Example Fix Submodule Issues and update list_code_examples Dec 27, 2024
@MeelahMe MeelahMe changed the title Fix Submodule Issues and update list_code_examples Fix Submodule Issues and updated/added list_code_examples Dec 27, 2024
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the list code examples. We should truncate/condense them like we discussed--sorry if that wasn't clear. Otherwise, they'll be too long in the section list page.

Suggestions:

Comment on lines 177 to +180
```
<!--pytest-codeblocks:cont-->

-->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment close tag at 190 needs to move up to close the opening at 174.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants