Add service tests to the logging job #153
Conversation
Add service tests to the logging job adding the tasks from #123 into a spearate PR
There was a problem hiding this comment.
As well as the comments inline, can you update the zuul job to run this? (based on #149)
| @@ -0,0 +1,13 @@ | |||
| --- | |||
| - name: "[TEST] verify container status" | |||
There was a problem hiding this comment.
The TEST prefix isn't chosen yet, so this may change
There was a problem hiding this comment.
The prefix will be "TEST"
| ansible.builtin.shell: | ||
| cmd: | | ||
| podman ps -a --format "{{ '{{.Names}} {{.Status}}' }}" | grep "{{ container_name }}" | awk '{print $2}' | ||
| changed_when: false |
There was a problem hiding this comment.
This needs a failed_when, if you're going to mark it with a TEST prefix, otherwise, it'll pass as long as the shell cmd returns something.
Alternatively, don't mark this task as a test, but mark the following task as a test.
Currently, we rely on the custom_logger to produce a file that gathers the test-ids=passed|failed output, so there should be a test ID in the second line of the task name.
Hopefully, we can remove this at some point soon, and add a check to report_result that checks the junit output instead.
| - name: Fail if container is not 'Up' | ||
| ansible.builtin.fail: | ||
| msg: "Container '{{ container_name }}' is not in 'Up' status. Current status: {{ container_status.stdout }}" | ||
| when: | ||
| - "'Up' not in container_status.stdout" |
There was a problem hiding this comment.
I like this, it makes it clear why the test failed.
However, this task should be the one one with TEST in the name.
roles/common/README.md
Outdated
| Requirements | ||
| ------------ | ||
|
|
||
| None |
roles/common/README.md
Outdated
| Role Variables | ||
| -------------- | ||
| Variable required for all tasks to run: | ||
|
|
There was a problem hiding this comment.
You should only be adding the container tests
| @@ -0,0 +1,13 @@ | |||
| --- | |||
| - name: "[TEST] verify container status" | |||
There was a problem hiding this comment.
The prefix will be "TEST"
roles/common/tasks/main.yml
Outdated
| vars: | ||
| container_name: "{{ item }}" | ||
|
|
||
| --- |
There was a problem hiding this comment.
| --- |
roles/common/tasks/main.yml
Outdated
| # All containers need to be up in order for this task to pass | ||
| - name: "[TEST] verify status of multiple containers" | ||
| ansible.builtin.include_tasks: | ||
| file: container_status.yml | ||
| loop: "{{ containers }}" | ||
| loop_control: | ||
| label: "{{ item }}" | ||
| vars: | ||
| container_name: "{{ item }}" | ||
|
|
There was a problem hiding this comment.
This is separate from adding the service checks.
It should NOT be run unconditionally
roles/common/tasks/main.yml
Outdated
| container_name: "{{ item }}" | ||
|
|
||
| --- | ||
| - name: "[TEST] Verify service for logging" |
There was a problem hiding this comment.
There should be a conditional here, so that the service_tests.yml will only be included when the right vars are defined
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7f0517696fab45e08af2d91c898eee4b ✔️ feature-verification-tests-noop SUCCESS in 4s |
adding the tasks from #123 into a spearate PR
https://issues.redhat.com/browse/OSPRH-9659
Depends-On: openstack-k8s-operators/openstack-operator#1115