Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jump compensation and change minimum overscan to 0 #198

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

inokawa
Copy link
Owner

@inokawa inokawa commented Oct 1, 2023

#315

  • check jump compensation in reverse scrolling works
  • check keyboard navigation works

@inokawa inokawa force-pushed the main branch 3 times, most recently from b91df5c to 257e20b Compare October 8, 2023 16:13
@inokawa inokawa force-pushed the main branch 2 times, most recently from d948497 to e98d44a Compare October 15, 2023 14:34
@inokawa inokawa force-pushed the main branch 5 times, most recently from 10ffb4c to b140eed Compare October 29, 2023 05:03
@inokawa inokawa force-pushed the main branch 6 times, most recently from ac99689 to 4c089dc Compare November 25, 2023 04:56
@inokawa inokawa force-pushed the main branch 2 times, most recently from c7502b6 to 79083a0 Compare December 9, 2023 11:13
@inokawa inokawa force-pushed the main branch 7 times, most recently from 6cb6dd5 to 9782943 Compare December 29, 2023 10:10
@inokawa inokawa force-pushed the main branch 2 times, most recently from a74242d to 173e5e2 Compare January 13, 2024 05:12
@inokawa inokawa marked this pull request as ready for review February 12, 2024 15:44
@inokawa inokawa changed the title Fix minimum overscan to 0 Improve jump compensation and change minimum overscan to 0 Feb 12, 2024
@inokawa inokawa merged commit 21d0e8e into main Feb 12, 2024
4 checks passed
@inokawa inokawa deleted the overscan-zero branch February 12, 2024 15:55
takecchi referenced this pull request in cuculus-dev/cuculus Feb 14, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [virtua](https://togithub.com/inokawa/virtua) | [`0.26.0` ->
`0.27.0`](https://renovatebot.com/diffs/npm/virtua/0.26.0/0.27.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/virtua/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/virtua/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/virtua/0.26.0/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/virtua/0.26.0/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

@coderabbitai: ignore

---

### Release Notes

<details>
<summary>inokawa/virtua (virtua)</summary>

### [`v0.27.0`](https://togithub.com/inokawa/virtua/releases/tag/0.27.0)

[Compare
Source](https://togithub.com/inokawa/virtua/compare/0.26.0...0.27.0)

- **BREAKING CHANGE**: Minimum value of `overscan` was 1 due to accuracy
issue, but now it's 0.

#### What's Changed

- Improve jump compensation and change minimum overscan to 0 by
[@&#8203;inokawa](https://togithub.com/inokawa) in
[https://github.com/inokawa/virtua/pull/198](https://togithub.com/inokawa/virtua/pull/198)
- Change minimum overscan to 0 by
[@&#8203;inokawa](https://togithub.com/inokawa) in
[https://github.com/inokawa/virtua/pull/375](https://togithub.com/inokawa/virtua/pull/375)
- Refactor and improve auto size estimation by
[@&#8203;inokawa](https://togithub.com/inokawa) in
[https://github.com/inokawa/virtua/pull/376](https://togithub.com/inokawa/virtua/pull/376)

**Full Changelog**:
inokawa/virtua@0.26.0...0.27.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cuculus-dev/cuculus).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant