Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated BUILT_BRANCH_SUFFIX input #147

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

tyrann0us
Copy link
Member

@tyrann0us tyrann0us commented Aug 6, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
Closes #146

What is the current behavior? (You can also link to an open issue here)
The deprecated BUILT_BRANCH_SUFFIX input is present. All calling workflows have been updated to use the newer BUILT_BRANCH_NAME.

What is the new behavior (if this is a feature change)?
The BUILT_BRANCH_SUFFIX input is removed.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, but no package uses the deprecated input anymore.

Other information:
I haven't tested this, so I'd appreciate it if one of you could give this a spin. Thanks!

Copy link
Contributor

@dottxado dottxado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works 💪

Co-authored-by: Volodymyr Shelmuk <[email protected]>
Signed-off-by: Philipp Bammes <[email protected]>
@luislard luislard merged commit b8fe99e into main Aug 22, 2024
1 check passed
@luislard luislard deleted the remove-deprecated-input branch August 22, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Remove BUILT_BRANCH_SUFFIX
5 participants