Upgrade cardano-api and cardano-cli to latest versions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
commented
May 3, 2024
| qfilter :: QueryUTxOFilter | ||
| qfilter = QueryUTxOByAddress $ Set.singleton address | ||
| query = QueryInShelleyBasedEra sbe (QueryUTxO qfilter) | ||
|
|
||
| aquireConnection :: Applicative f => m (Net.Query.ClientStAcquired block point query m a) -> f (Net.Query.ClientStIdle block point query m a) | ||
| aquireConnection aquireComplete = do | ||
| pure $ Net.Query.SendMsgAcquire Nothing $ Net.Query.ClientStAcquiring | ||
| pure $ Net.Query.SendMsgAcquire VolatileTip $ Net.Query.ClientStAcquiring |
There was a problem hiding this comment.
@disassembler> I've chosen to use VolatileTip here, is that what we want?
smelc
commented
May 3, 2024
| @@ -144,12 +143,12 @@ runQueryThen query queryDone = do | |||
|
|
|||
| reAcquireThen :: m (Net.Query.ClientStAcquired block point query m a) -> IO (Net.Query.ClientStAcquired block point query m a) | |||
| reAcquireThen cb = do | |||
| pure $ Net.Query.SendMsgReAcquire Nothing $ Net.Query.ClientStAcquiring | |||
| pure $ Net.Query.SendMsgReAcquire VolatileTip $ Net.Query.ClientStAcquiring | |||
There was a problem hiding this comment.
@disassembler> I've chosen to use VolatileTip here, is that what we want?
disassembler
force-pushed
the
smelc/node-8.10.0-pre
branch
from
d318cc1 to
f0e6931
Compare
disassembler
approved these changes
May 6, 2024
disassembler
force-pushed
the
smelc/node-8.10.0-pre
branch
from
0923930 to
890d4d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR has a SRP to
cardano-cli. It will soon be removed as we releasecardano-cli.Prerequisites
cardano-api: Release cardano-api-8.45.2.0 IntersectMBO/cardano-api#528cardano-cli(with upgradedcardano-apifrom first item)cardano-cliin this PRContext
Upgrades
cardano-apiandcardano-clito latest versionsHow to trust this PR
Well, this was a blind change, entirely compiler-guided, since there are not tests in this repo, so 🤞