-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensures required packages are in Imports section #774
base: main
Are you sure you want to change the base?
Changes from 10 commits
e2275ab
4590f44
8484c82
a87ccd1
3015749
b083bc4
fcedb3c
98ae21c
27a75ad
8d1c172
ad8ba68
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,16 +31,30 @@ Depends: | |
teal.transform (>= 0.5.0.9015) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Teal requirement needs to be bumped with insightsengineering/teal#1432 Possibly to Keeping conversation open until the PR is closed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I approved that PR, so working on this PR can continue. |
||
Imports: | ||
checkmate (>= 2.1.0), | ||
colourpicker, | ||
dplyr (>= 1.0.5), | ||
DT (>= 0.13), | ||
forcats (>= 1.0.0), | ||
generics, | ||
ggExtra, | ||
ggpmisc (>= 0.4.3), | ||
ggpp, | ||
ggrepel, | ||
goftest, | ||
grid, | ||
gridExtra, | ||
htmlwidgets, | ||
jsonlite, | ||
lattice (>= 0.18-4), | ||
MASS, | ||
rtables (>= 0.6.8), | ||
llrs-roche marked this conversation as resolved.
Show resolved
Hide resolved
|
||
lifecycle (>= 0.2.0), | ||
scales, | ||
shinyjs, | ||
shinyTree (>= 0.2.8), | ||
shinyvalidate, | ||
shinyWidgets (>= 0.5.1), | ||
sparkline, | ||
stats, | ||
stringr (>= 1.4.1), | ||
teal.code (>= 0.5.0.9012), | ||
|
@@ -54,50 +68,34 @@ Imports: | |
tools, | ||
utils | ||
Suggests: | ||
broom (>= 0.7.10), | ||
colourpicker, | ||
ggExtra, | ||
ggpmisc (>= 0.4.3), | ||
ggpp, | ||
ggrepel, | ||
goftest, | ||
gridExtra, | ||
htmlwidgets, | ||
jsonlite, | ||
knitr (>= 1.42), | ||
lattice (>= 0.18-4), | ||
logger (>= 0.2.0), | ||
MASS, | ||
nestcolor (>= 0.1.0), | ||
pkgload, | ||
rlang (>= 1.0.0), | ||
rmarkdown (>= 2.23), | ||
roxy.shinylive, | ||
rtables (>= 0.6.8), | ||
rvest, | ||
shinytest2, | ||
sparkline, | ||
testthat (>= 3.1.9), | ||
withr (>= 2.0.0) | ||
VignetteBuilder: | ||
knitr, | ||
rmarkdown | ||
Config/Needs/verdepcheck: haleyjeppson/ggmosaic, tidyverse/ggplot2, | ||
rstudio/shiny, insightsengineering/teal, | ||
insightsengineering/teal.transform, mllg/checkmate, tidyverse/dplyr, | ||
rstudio/DT, tidyverse/forcats, r-lib/lifecycle, r-lib/scales, | ||
daattali/shinyjs, shinyTree/shinyTree, rstudio/shinyvalidate, | ||
dreamRs/shinyWidgets, tidyverse/stringr, | ||
Config/Needs/verdepcheck: tidyverse/ggplot2, | ||
rstudio/shiny, insightsengineering/teal, insightsengineering/teal.transform, | ||
mllg/checkmate, daattali/colourpicker, tidyverse/dplyr, rstudio/DT, | ||
tidyverse/forcats, daattali/ggExtra, aphalo/ggpmisc, aphalo/ggpp, | ||
slowkow/ggrepel, baddstats/goftest, ramnathv/htmlwidgets, jeroen/jsonlite, | ||
deepayan/lattice, insightsengineering/rtables, r-lib/lifecycle, | ||
r-lib/scales, daattali/shinyjs, shinyTree/shinyTree, rstudio/shinyvalidate, | ||
dreamRs/shinyWidgets, htmlwidgets/sparkline, tidyverse/stringr, | ||
insightsengineering/teal.code, insightsengineering/teal.data, | ||
insightsengineering/teal.logger, insightsengineering/teal.reporter, | ||
insightsengineering/teal.widgets, insightsengineering/tern, | ||
tidyverse/tibble, tidyverse/tidyr, tidymodels/broom, | ||
daattali/colourpicker, daattali/ggExtra, aphalo/ggpmisc, aphalo/ggpp, | ||
slowkow/ggrepel, baddstats/goftest, ramnathv/htmlwidgets, | ||
jeroen/jsonlite, yihui/knitr, daroczig/logger, deepayan/lattice, | ||
tidyverse/tibble, tidyverse/tidyr, yihui/knitr, daroczig/logger, | ||
insightsengineering/nestcolor, r-lib/pkgload, r-lib/rlang, | ||
rstudio/rmarkdown, insightsengineering/roxy.shinylive, | ||
insightsengineering/rtables, tidyverse/rvest, htmlwidgets/sparkline, | ||
rstudio/rmarkdown, insightsengineering/roxy.shinylive, tidyverse/rvest, | ||
rstudio/shinytest2, r-lib/testthat, r-lib/withr | ||
Config/Needs/website: insightsengineering/nesttemplate | ||
Encoding: UTF-8 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see changes in dependencies and I immediately think about verdepcheck. Can you please confirm that it is passing on this? If not - let's work on the deps versions.
This might need to wait for https://github.com/insightsengineering/teal.modules.general/pull/774/files#r1890465398