Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESOURCE-313 GCP - Replace attribute() calls with input() calls in integration tests #404

Closed
wants to merge 7 commits into from
Closed

RESOURCE-313 GCP - Replace attribute() calls with input() calls in integration tests #404

wants to merge 7 commits into from

Conversation

soumyo13
Copy link
Contributor

@soumyo13 soumyo13 commented Mar 12, 2022 •
edited
Loading

Signed-off-by: Soumyodeep Karmakar [email protected]

Description

  1. Changed the "input" from "attribute" in the integration test.
  2. Changed the "value" from "default" in the integration test.
  3. Formatted the code.
  4. Uncomments the unused attributes.

Issues Resolved

#403

Please ensure commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

@soumyo13
upto generic_windows_internal_vm
e5004a3 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13 soumyo13 requested a review from a team as a code owner March 12, 2022 07:31
soumyo13 added 6 commits March 12, 2022 13:15
@soumyo13
updated the value
59ff5df 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13
updated the input from attribute
24a2e2a 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13
updated the input from attribute
d3f4668 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13
updated the input from attribute
e540c7e 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13
updated the input from attribute and value from default
a99b3b9 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13
commented the unused and formatted the code
3f102d2 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13 soumyo13 self-assigned this Mar 12, 2022
@soumyo13 soumyo13 added the enhancement New feature or request label Mar 12, 2022
@soumyo13 soumyo13 linked an issue Mar 12, 2022 that may be closed by this pull request
replace attribute calls with input calls so inspec 4.52+ works #403
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soumyo13 soumyo13

Labels
DO_NOT_MERGE enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace attribute calls with input calls so inspec 4.52+ works
2 participants
@soumyo13 @sa-progress