This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Bibupload improvements #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates the way external file format detection is happening, by trying to compare file extensions detected from downloaded file with expected MIME-type or extension. * Improves the error message when formats are different. Signed-off-by: Jan Aage Lavik <[email protected]>
* Changes to use the filedownloadutils.download_url() function instead of bibdocfile.download_url() in order to benefit from (1) timeout and retry mechanics, and (2) improved format detection. * BibUpload will now abort the FFT update should the format received from the given URL be different than the docformat expected. Signed-off-by: Jan Aage Lavik <[email protected]>
* Improves the bibdocfile.file_strip_ext() function to work with cases where the same extension is doubled, for example if the URL would be "foo.pdf.pdf" now only the first ".pdf" is stripped. * Adds a new file with BibDocFile unit tests and implements tests for file_strip_ext. Signed-off-by: Jan Aage Lavik <[email protected]>
|
You already rebased it against latest prod? |
|
@kaplun Yep, it is. |
kaplun
force-pushed
the
prod
branch
2 times, most recently
from
c164f1f to
dfde96b
Compare
|
|
for me. Maybe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revived branch that we should have a look at again.
Basically, it deals with proper downloading from FFT tags and content type detection. Avoiding, say, uploading HTML as PDF etc.
@kaplun @tsgit