Feat: sebulba rec ippo #1142
Open
Feat: sebulba rec ippo #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonDuToit
requested review from
RuanJohn,
sash-a,
OmaymaMahjoub,
WiemKhlifi and
Louay-Ben-nessir
as code owners
OmaymaMahjoub
requested changes
Dec 11, 2024
| - arch: sebulba | ||
| - system: ppo/rec_ippo | ||
| - network: rnn # [mlp, continuous_mlp, cnn] | ||
| - env: lbf_gym # [rware_gym, lbf_gym] |
There was a problem hiding this comment.
if you can add smaclite_gym to the list
| observation: Observation, | ||
| dones, | ||
| hstates, | ||
| key: chex.PRNGKey, |
There was a problem hiding this comment.
Suggested change
| key: chex.PRNGKey, | |
| dones: chex.Array, | |
| hstates: HiddenStates, |
| @@ -0,0 +1,910 @@ | |||
| # Copyright 2022 InstaDeep Ltd. All rights reserved. | |||
There was a problem hiding this comment.
If you can update the typings in Pipeline mava/utils/sebulba.py to be Union[PPOTransition, RNNPPOTransition]
| log_prob = actor_policy.log_prob(action) | ||
| # It may be faster to calculate the values in the learner as | ||
| # then we won't need to pass critic params to actors. | ||
| # value = critic_apply_fn(params.critic_params, observation).squeeze() |
There was a problem hiding this comment.
if you can remove this comment
| timestep = env.reset(seed=seeds) | ||
| dones = np.repeat(timestep.last(), num_agents).reshape(num_envs, -1) | ||
|
|
||
| # simon |
There was a problem hiding this comment.
same here once you are done from cleaning, if you can remove this comment
There was a problem hiding this comment.
I see this comment exists in multiple lines, if you can remove them all
| ) | ||
|
|
||
| params, opt_states, traj_batch, advantages, targets, key = update_state | ||
| # learner_state = LearnerState(params, opt_states, key, None, learner_state.timestep) |
There was a problem hiding this comment.
If you can remove this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sebulba implementation of recurrent IPPO.