Editorialize greasing considerations #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfpauly
approved these changes
May 7, 2024
draft-edm-protocol-greasing.md
Outdated
| unintentionally use grease values, which could lead to interoperability | ||
| failures. | ||
|
|
||
| Fields that use grease values should request that IANA requests allocate only a |
There was a problem hiding this comment.
Suggested change
| Fields that use grease values should request that IANA requests allocate only a | |
| Fields that use greased values should request that IANA requests allocate only a |
Is this right?
There was a problem hiding this comment.
I was attempting keep keep consistency with
Values
reserved for the purpose of greasing are herein referred to as grease values.
but really, I don't think "fields that x" can request anything from IANA because they are inanimate objects 😂. Will take another stab.
draft-edm-protocol-greasing.md
Outdated
| implementation non-determinism of when they use grease in addition to what | ||
| values they send. | ||
|
|
||
| Values in the grease value set must not be used or registered for any other |
This attempts to make the recommendations clearer by reducing some fluff and combining some paragraphs. Effectively putting all the concerns about grease values together, followed by registration considerations.
LPardue
force-pushed
the
grease-section-editorial
branch
from
3a10312 to
1d24356
Compare
Co-authored-by: Tommy Pauly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to make the recommendations clearer by reducing some
fluff and combining some paragraphs. Effectively putting all the
concerns about grease values together, followed by registration
considerations.