Break greasing recommendations into sub-sections #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfpauly
reviewed
Jul 26, 2024
Co-authored-by: Tommy Pauly <[email protected]>
dthaler
reviewed
Jul 26, 2024
gorryfair
reviewed
Jul 26, 2024
| @@ -100,12 +100,16 @@ Implementations that receive grease values are required to ignore them. More | |||
| background to this approach is given in {{Section 3.3 of ?VIABILITY=RFC9170}}. | |||
| This section provides concrete suggestions for its usage. | |||
|
|
|||
| ## Don't Special-Case Grease Values | |||
|
|
|||
There was a problem hiding this comment.
Is this clearer as: Don't make Grease Values a Special Case?
There was a problem hiding this comment.
I took the suggestion and mashed it up a little
Co-authored-by: Dave Thaler <[email protected]>
dthaler
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20