-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT]: issue_label doesn't work for Organizations #1840
Comments
Great catch! Do you have the interest/inclination to open up a PR to fix this behavior? |
Yes, I'd be happy to open a PR for this. May need a little guidance for getting started, but I should be able to get to this in a couple of weeks. |
Awesome! Our CONTRIBUTING.md, especially this section about how to build the provider so it's invoked in your local Terraform runs. For full debugging, this section is the one to read. |
Apologies for the delay in getting this, but I've got a PR up that should address this! |
👋 Hey Friends, this issue has been automatically marked as |
Hey @ikegentz - any chance you're still working on that PR? |
Hey @ksatirli , I totally forgot about that PR ( #2052 ) TBH for a while there, but just took a look at it again so will be trying to get it merged in here. The PR is actually done (need to rebase it), but there's an open question on there that's keeping us from merging it, so if you've got any input there feel free to chime in |
Describe the need
There is currently no way to create an issue_label for a repo owned by an organization, rather than the account on which the PAT is used for authentication in the provider.
Specifically, the
repository
attribute in thegithub_issue_label
resource is hard-coded to this format:https://api.github.com/repos/<PAT user>/
, meaning if you try to pass<my organization>/<repo>
, you'll end up withhttps://api.github.com/repos/<PAT user>/<my organization>/<repo>
.The API already supports an
owner
argument, so it seems like that could be exposed in the resource so that this would work.SDK Version
No response
API Version
No response
Relevant log output
Code of Conduct
The text was updated successfully, but these errors were encountered: