-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Org Option to issue_label #2052
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I'm a little torn as to whether we want to standardize on owner
instead of org
here. I think it would be better to be consistent with the keywords we use at the provider level...what do you think?
Wow I totally forgot about this PR, sorry for the delay! Hm, IMO the current version of the provider is confusing because an owner of a repo doesn't have to be an organization, it could be an individual too. So on https://registry.terraform.io/providers/integrations/github/latest/docs#authentication, we have this example:
specifically, That said, perhaps there are some other implications to doing this I am not considering outside of the current context of this PR. Look forward to your thoughts on this @kfcampbell |
Resolves #1840
Before the change?
github_issue_label
resource to specify an Organization in which the repo you wanted to create the label for, livedAfter the change?
org
attribute to thegithub_issue_label
resource that lets the end-user explicitly specify where the repo lives they want to add the label toPull request checklist
NOTE: I updated the docs in
website/docs/r/
, because they matched what I see on the resource's documentation page but do I need to update something inwebsite/docs/d/
? What is that directory for?Does this introduce a breaking change?
Nothing I'm aware of!