Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: branch_protection - added missing App DismissalActorTypes #1896

Merged
merged 2 commits into from
Sep 27, 2023
Merged

[bug]: branch_protection - added missing App DismissalActorTypes #1896

merged 2 commits into from
Sep 27, 2023

Conversation

dion-gionet
Copy link
Contributor

Resolves #1895

Before the change?

  • Constant diff on github_branch_protection.required_pull_request_reviews.dismissal_restrictions even after applying a plan that includes a Github App actor ID

After the change?

  • No diff on github_branch_protection.required_pull_request_reviews.dismissal_restrictions after applying a plan that includes a Github App actor ID

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

nickfloyd
nickfloyd approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dion-gionet thank you for this contribution ❤️

@nickfloyd nickfloyd changed the title fix(branch_protection): added missing App DismissalActorTypes [bug]: branch_protection - added missing App DismissalActorTypes Sep 27, 2023
@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Sep 27, 2023
@nickfloyd nickfloyd merged commit 2cd8a94 into integrations:main Sep 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: branch_protection missing App DismissalActorTypes
2 participants
@dion-gionet @nickfloyd