Fix organization ruleset conditions schema validation, update docs #1911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1899 & #1909
Before the change?
organization_ruleset.conditions.0
was partially broken.repository_name
andrepository_id
.repository_name
norrepository_id
.bypass_actors
didn't specify anything related toactor_id
when setting type toOrganizationAdmin
, the API docs also don't mention anything but the expected value is1
as tested by @YElyousfi.After the change?
repository_name
andrepository_id
is required for organization rulesets conditions, previously this would fail on apply since the API requires at least one to be set alongsideref_name
. This shouldn't require a major version change because requests sent using the previous iteration weren't actually succeeding, so there shouldn't be a state change or breakage of existing use.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!