[bug]: Fix hostname used with gh CLI for github.com
#1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfloyd
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
@divergentdave thank you for getting this wrapped up for us. ❤️
nickfloyd
changed the title
gh CLI for github.comgh CLI for github.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1905
Before the change?
gh auth tokendoes not work with repositories ongithub.com.After the change?
--hostnamevalue passed to the subcommand in this case.Pull request checklist
Does this introduce a breaking change?
This implements the revised fix I suggested in #1905 (comment).