-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: update comments for github_branch_protection in case of push_restrictions #1945
Conversation
Awesome, Mishin, but I'd like to suggest your examples include a mix of team/user. This was the original problem with the documentation, that it was shown as a bug. But In your examples, it isn't really demonstrating the way this can be overcome. Thanks for working this!! |
Added suggestions. Thanks again, Mishin! |
Co-authored-by: Tyler <[email protected]>
Co-authored-by: Tyler <[email protected]>
macetw, thank you for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Mishin!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Nmishin thank you for these contributions! ❤️
Resolves #1841
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!