Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe how actor_id / integration_id can be found #2474

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Nov 25, 2024

Resolves #2473


Before the change?

  • its' unclear what integration_id is and how to get.

After the change?

  • Users can find how to get integration_id.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@mikutas mikutas marked this pull request as ready for review November 25, 2024 07:16
@stevehipwell
Copy link
Contributor

@mikutas do you think it'd be worth adding the value for GitHub Actions directly into the docs? I think it's a global value of 15368 for everyone.

gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /apps/github-actions

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thank you!

website/docs/r/repository_ruleset.html.markdown Outdated Show resolved Hide resolved
website/docs/r/repository_ruleset.html.markdown Outdated Show resolved Hide resolved
@kfcampbell kfcampbell merged commit 3866012 into integrations:main Nov 26, 2024
3 checks passed
MXfive pushed a commit to MXfive/terraform-provider-github that referenced this pull request Nov 27, 2024
…ations#2474)

* update r/repository_ruleset

* Update website/docs/r/repository_ruleset.html.markdown

* Update website/docs/r/repository_ruleset.html.markdown

---------

Co-authored-by: Keegan Campbell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS]: Document how actor_id / integration_id can be found
3 participants