[HIP] Mark assert tests unsupported / 2dmem tests Xfail. #12955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to ROCm/HIP#3368 Signed-off-by: JackAKirk <[email protected]>
|
Please change the PR title/description to make it clear that the tests are marked as unsupported rather than XFAIL. |
JackAKirk
changed the title
Done, thanks. |
sergey-semenov
approved these changes
Mar 8, 2024
JackAKirk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: JackAKirk <[email protected]>
JackAKirk
changed the title
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
|
This pull request was closed because it has been stalled for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Device assert broken on gfx1030 with "Bus error", or hanging after synchronize ROCm/HIP#3368
The two assert tests were originally missed because they are flaky and didnt fail in #7634
But the assert problem on hip rdna2 cards such as the CI in intel/llvm (see ROCm/HIP#3368 (comment)) appears to affect all basic use of assert, and they are leading to timeouts currently #12909