-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][P2P] Fix info query for P2P #15873
Conversation
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
@bso-intel Could you take a quick look at this so that we can merge these fixes? Cmake will be updated when oneapi-src/unified-runtime#2246 is merged, so no need to worry about that. Thanks |
I merged the UR PR, please update the tags. |
Signed-off-by: JackAKirk <[email protected]>
Thanks, done. |
@intel/llvm-reviewers-runtime please review, this is blocking UR updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor suggestion.
initialize value Co-authored-by: Udit Agarwal <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
All reviewers comments have been resolved and the UR tag is already updated. @intel/llvm-gatekeepers this is ready to merge. |
@JackAKirk Could this HIP postcommit failure be related?
https://github.com/intel/llvm/actions/runs/11612687147/job/32337271582 |
From looking at that Graph test and its includes I don't see how this PR could be related to that failure. We have raised this issue several times both internally to line-management (and above) as well as via public issues. Here are a few examples I quickly found: |
There has been some confusion I think originating in the fact that L0 backend returned bool type instead of int for P2P queries. This issue is fixed here oneapi-src/unified-runtime#2246
This PR correspondingly updates the dpc++ runtime.
Fixes #15841