Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stripe): integrate pay-by-card #45

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

beniaminmunteanu
Copy link
Member

@beniaminmunteanu beniaminmunteanu commented Dec 15, 2024

This PR implements stripe integration, by utilising stripe 'advanced integration' options:
PaymentIntents for registering the payment
and PaymentElements for embedding a form

The implementation serves as reference for integrating "pay by card" functionality in interledger-pay.

Following flow is implemented:
image
(delimited by the horizontal red line, the final webhooks are not implemented here. These need to be implemented in the Wallet backend- testnet repo)

Note: Implementation is not final.
TBD In order to close #41 and #42 :

  • The Pay by card option should only be visible based on env. variables, as interledger-pay deployment should not be affected. The changes in this PR should only be applied on a separate image that is used when reverse proxy responds to wallet address request with the pay-by-card enabled interledger-pay image
  • PR is functionality oriented, and frontend design needs work.
  • The receiver wallet address should be pre-filled from url.

P.S.
For local testing, change sameSite to 'lax'

sameSite: 'none',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants