feat(frontend): manage incoming auth tokens #2935
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
reviewed
Sep 16, 2024
furkan-bilgin
force-pushed
the
main
branch
2 times, most recently
from
62ece89 to
0a1bdbf
Compare
Co-authored-by: Max Kurapov <[email protected]>
…uthTokens` as `string[]`
oana-lolea
approved these changes
Sep 25, 2024
mkurapov
reviewed
Oct 31, 2024
| @@ -122,6 +122,9 @@ export const peerToGraphql = (peer: Peer): SchemaPeer => ({ | |||
| id: peer.id, | |||
| maxPacketAmount: peer.maxPacketAmount, | |||
| http: peer.http, | |||
| incomingTokens: peer.incomingTokens?.map( | |||
There was a problem hiding this comment.
I think incomingTokens would probably benefit from a separate resolver kind of like liquidity is done. Check packages/backend/src/graphql/resolvers/index.ts. This will require a new function in the HttpTokenService instead of doing .withGraphFetched('incomingTokens') in the getter in peer service.
|
Hi @furkan-bilgin for the last comment, is it something you'd like to do or should I get someone from the team to make the change? |
4 tasks
4 tasks
|
Hi @mkurapov, sorry for the late reply. I am now working on the things you've pointed out. If this PR is still relevant, I'll be commiting my changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
fixes #2765
Checklist
fixes #number