chore: remove mentioning of not spec'ed Route Broadcasting Protocol #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabineschaller
commented
Nov 4, 2024
| @@ -38,7 +38,7 @@ Connectors provide a service of forwarding packets and relaying money, and they | |||
|
|
|||
| Like the Internet protocol stack that inspired it, the Interledger protocol suite is divided into layers of protocols with different responsibilities. Lower-level protocols provide basic functionality that higher-level protocols depend on to provide more complex functionality. | |||
|
|
|||
| > **Aside:** Not pictured in the diagram are configuration protocols including [IL-RFC-31: Interledger Dynamic Configuration Protocol](../0031-dynamic-configuration-protocol/0031-dynamic-configuration-protocol.md) and **Route Broadcasting Protocol**. These protocols are built on top of the Interledger Protocol layer and support it, but are not considered to be transport or application-layer protocols. | |||
| > **Aside:** Not pictured in the diagram are configuration protocols including [IL-RFC-31: Interledger Dynamic Configuration Protocol](../0031-dynamic-configuration-protocol/0031-dynamic-configuration-protocol.md) or a route broadcasting protocol (not specified yet). These protocols are built on top of the Interledger Protocol layer and support it, but are not considered to be transport or application-layer protocols. | |||
There was a problem hiding this comment.
made it generic and pointed out that it wasn't spec'ed out yet
sabineschaller
commented
Nov 4, 2024
| - Nodes are connected to each other and the relationship between two nodes is either: | ||
| - `parent` and `child` (one node is the `parent` of another node that is relatively its `child`), or, | ||
| - `peer` and `peer` (two nodes are peered with one another). | ||
|
|
||
| ## Overview | ||
| Interledger is a protocol suite that consists of several protocols including the [Bilateral Transfer Protocol](../0023-bilateral-transfer-protocol/0023-bilateral-transfer-protocol.md), the Route Broadcasting Protocol and others necessary for establishment, operation and maintenance of the network. Interledger Dynamic Configuration Protocol (ILDCP) is one of these protocols. | ||
|
|
||
| Interledger is a protocol suite that consists of several protocols including the [Bilateral Transfer Protocol](../0023-bilateral-transfer-protocol/0023-bilateral-transfer-protocol.md) or [ILP over HTTP](../0035-ilp-over-http/0035-ilp-over-http.md) and others necessary for establishment, operation and maintenance of the network. Interledger Dynamic Configuration Protocol (ILDCP) is one of these protocols. |
There was a problem hiding this comment.
Added ILP over HTTP and removed Route Broadcasting Protocol. I did wonder what "and others necessary" would include.
sabineschaller
requested review from
adrianhopebailie,
justmoon,
AlexLakatos,
matdehaast and
mkurapov
mkurapov
reviewed
Nov 6, 2024
0031-dynamic-configuration-protocol/0031-dynamic-configuration-protocol.md
Outdated
Show resolved
Hide resolved
0031-dynamic-configuration-protocol/0031-dynamic-configuration-protocol.md
Outdated
Show resolved
Hide resolved
…-protocol.md Co-authored-by: Max Kurapov <[email protected]>
…-protocol.md Co-authored-by: Max Kurapov <[email protected]>
sabineschaller
commented
Nov 19, 2024
Comment on lines
-87
to
+97
| - RBP is a protocol built on top of ILP, and is used for transferring routing information to build routing tables. | ||
| - RBP data is put into the extensible data area of ILP packets. | ||
| - A Route Broadcasting Protocol is thought to be a protocol built on top of ILP, and would be used for transferring routing information to build routing tables. | ||
| - RBP data would be put into the extensible data area of ILP packets. | ||
| - RBP is an idea that does not exist yet. |
There was a problem hiding this comment.
I made this section hypothetical. If we want to completely remove it, we need to change the svgs and the numbering.
There was a problem hiding this comment.
To me, the third point is already implied by the first one
There was a problem hiding this comment.
We can imply that something does exist, but it is not part of the official spec but simply EXPERIMENTAL, which we can still link to. The experimental spec can link to the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also did some auto cleanup. I'll highlight the 2 main changes in comments.