Improve fetching HoF hosters (#1569)

Fixes #1568.
internetstandards · Dec 2, 2024 · 6cd809c · 6cd809c
1 parent cada33e
commit 6cd809c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/docker/cron/periodic/15min/download_hof b/docker/cron/periodic/15min/download_hof
@@ -8,4 +8,12 @@ fi
 
 cd /app/manual-hall-of-fame/
 
-curl -fsSL "$HOSTERS_HOF_URL" > /app/manual-hall-of-fame/hosters.yaml
+ETAG_FILE='/app/manual-hall-of-fame/hosters.etag';
+
+if [ ! -f "$ETAG_FILE" ]; then
+  touch "$ETAG_FILE"
+fi
+
+if HEADERS=$(curl --compressed -sSfL -H "If-None-Match: $(cat "$ETAG_FILE")" "$HOSTERS_HOF_URL" -o '/app/manual-hall-of-fame/hosters.yaml' -D-); then
+  echo "$HEADERS" | grep -ioE '^etag: [^\r\n]+' | cut -c6- > "$ETAG_FILE"
+fi
diff --git a/integration_tests/integration/test_hof.py b/integration_tests/integration/test_hof.py
@@ -9,7 +9,7 @@ def test_cron_manual_hosters_hof(page, app_url, trigger_cron):
 
     page.goto(app_url)
     page.get_by_role("link", name="Hall of Fame", exact=True).click()
-    page.get_by_text("Hosters").click()
+    page.get_by_text("Hosters", exact=True).click()
 
     hof_content = page.locator(".hof-content")