Refs #1510: resets path variable so legacy path error is used #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the legacy security.txt location only, the SecuritytxtRetrieveResult accidentally still contained the .well-known path. This PR fixed this by resetting the path variable if the legacy path is used and the .well-known path is not.
This will not change anything when both the .well-known AND the legacy path are used (even when the legacy path contains a different security.txt) as is discussed in #1510 as well. It could be argued that this is according to the spec:
But we could also argue that this is such bad practice that we want to provide an error for that later.