Add compose monitoring profile #1589
Conversation
bwbroersma
commented
Dec 9, 2024
•
bwbroersma
commented
- Fixes Options to only create main part of internet.nl Batch API (Django) #1588
|
The number of profiles seems to be rapidly expanding. We've had a dev misconfiguration for them already. I think we need one place in the deployment docs where they are all listed, along with defaults and recommendations. Particularly as misconfiguration may not be immediately obvious. |
|
Agree, also wonder if all services with the It seems after this addition there are these profiles defined in the compose files:
I see Line 5 in 0e5a6d1 Internet.nl/docker/batch-test.env Line 11 in 0e5a6d1 However, its unused in all compose files. |
Removing the unused batch profile from env. Adding the alertmanager profile to all monitoring services.
| @@ -752,6 +753,10 @@ services: | |||
| internal: | |||
| ipv4_address: $IPV4_IP_GRAFANA_INTERNAL | |||
|
|
|||
| profiles: | |||
| - alertmanager | |||
There was a problem hiding this comment.
I don't think alertmanager needs to be specified here (and the others). Thought doesn't make sense to enable alertmanager profile without the monitoring profile also enabled. It might be better to keep them separated.
| @@ -1,6 +1,6 @@ | |||
| # Metrics | |||
|
|
|||
| The Docker deployment includes a metrics collection system which is available on production as well as development/test environments. It consists of a Prometheus metrics server which scrapes metrics from various exporters. Grafana is provided as frontend to visualise metrics and create graphs/dashboards. | |||
| The Docker deployment includes a metrics collection system which is available on production as well as development/test environments. It consists of a Prometheus metrics server which scrapes metrics from various exporters. Grafana is provided as frontend to visualise metrics and create graphs/dashboards. The various exporters, Prometheus and Grafana containers can be disabled by not loading the `monitoring` profile, by overriding the default profiles with e.g. `COMPOSE_PROFILES=cron` in `local.env`. | |||
There was a problem hiding this comment.
I think we should refrain from giving these kinds of instructions for COMPOSE_PROFILES completely (for which I'm guilty of as well). And go with @mxsasha idea #1589 (comment) and have 1 place in the documentation to refer to with a table with all possible permutations of COMPOSE_PROFILES (that are sane at least) and have them copy pasteable so there is no ambiguity.
