Add parameters to database availability pings, show waiting message #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierenevans
reviewed
May 27, 2024
| @@ -25,6 +25,10 @@ function task_database_available() | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if ! (( counter % 5 )); then | |||
| echo "Waiting for database to become available: '${command}'" | |||
There was a problem hiding this comment.
Careful about printing the database password out for mysql. Maybe direct to stderr too?
There was a problem hiding this comment.
Suggested change
| echo "Waiting for database to become available: '${command}'" | |
| echo "Waiting for database '$DB_HOST' to become available" >&2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps a bit with finding out why
task:initwaits forever :)