Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey path not loading in VSCode 1.74.0 #55

Open
golimpio opened this issue Dec 8, 2022 · 20 comments
Open

Monkey path not loading in VSCode 1.74.0 #55

golimpio opened this issue Dec 8, 2022 · 20 comments

Comments

@golimpio
Copy link

golimpio commented Dec 8, 2022

VSCode won't start. I'm testing it on macOS 13.0.1

❯ code --version
1.74.0
5235c6bb189b60b01b1f49062f4ffa42384f8c91
x64
❯ code --verbose
Loading monkey-patch
(node:56390) UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading 'crypto')
    at P (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:25:24056)
    at i (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:25:33504)
    at get mainIPCHandle (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:32:6945)
    at p.<computed> (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:3:53298)
    at Oe.c (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:7310)
    at Oe.b (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:5809)
    at Oe.a (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:4864)
    at Oe.main (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:4709)
    at Object.<anonymous> (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:85:1732)
    at s._safeInvokeFunction (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1337)
    at s._invokeFactory (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1522)
    at s.complete (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1801)
    at s._onModuleComplete (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1112)
    at s._onModuleComplete (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1358)
    at s._resolve (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:510)
    at s.defineModule (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:6066)
    at n (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:10527)
    at Object.R (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:6036)
    at s._safeInvokeFunction (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1337)
    at s._invokeFactory (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1522)
    at s.complete (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:1801)
    at s._onModuleComplete (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1112)
    at s._onModuleComplete (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1358)
    at s._resolve (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:510)
    at s.defineModule (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:6066)
    at y (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:6:1825)
    at h (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:2554)
    at Object.<anonymous> (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.nls.js:3:61)
    at e._createAndEvalScript (/Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:2598)
    at /Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:2237
    at /Applications/Dev/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js:82:14
    at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3)
(Use `Electron --trace-warnings ...` to show where the warning was created)
(node:56390) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
@sstativa
Copy link

sstativa commented Dec 8, 2022

Same error, but on Apple Silicon.

@golimpio
Copy link
Author

golimpio commented Dec 8, 2022

I think this was explained here by the author:
iocave/customize-ui#156

@JackEllis
Copy link

+1 also having issues. I apply monkey patch and then VS Code won't open after a restart. This is a monkey patch to hide the top bar.

Solution for now is to re-install the Mac app (download & overwrite .app file) and just not run the monkey patch.

@rockyoung
Copy link

rockyoung commented Dec 8, 2022

Same error, but on Windows

20221208141833

so should I have to reinstall the vscode to solve this issue?

@NetanelH2
Copy link

NetanelH2 commented Dec 8, 2022

It happens to me as well in macOS.
The only solution I found so far is to go back to vscode version 1.73.

NOTE:
Cancel vs code auto update feature so I won't force update to 1.74.

@tuxmanu
Copy link

tuxmanu commented Dec 8, 2022

Same here, not able to start VSC after updating to 1.74.0 and re-applying monkeypatch. on MacOs 12.6.1

@owencyr
Copy link

owencyr commented Dec 8, 2022

long story short there was a breaking change in 1.74. Either downgrade to 1,73, or disable monkeypatch + customize UI

@lethefrost
Copy link

Same here, waiting for an update. Is it forever broken or does there exist any workaround? Thank you so much for this awesome extension ❤️

@jbaum012
Copy link

Here's a link to 1.73. On mac you just need to download this version and replace the .app in your applications folder

@johnnyshankman
Copy link

Ran into this today. Glad this thread was here to make me not feel insane 👍 a fix would be awesome

@OneTuskedMario
Copy link

Looking at the customize ui thread started by the author it seems it is forever going to be broken because vscode changed a fundamental mechanic on how their typescript private fields are accessed. The only workaround for now is downgrading as far as I know

@sstativa
Copy link

sstativa commented Dec 19, 2022

In theory, if the Monkey patch was used only for CustomizeUI and a simple CSS customization, some of these customisations might be reproduced directly in Contents/Resources/app/out/vs/workbench/workbench.desktop.main.css.
Of course, VSCode will throw a warning on start but at least it can be suppressed and won't bother you till the next update of VSCode.

@Xelbayria
Copy link

I have the same problem where I re-apply MonkeyPatch and then restart VSC. It doesn't open at all after restarting.
my OS is: Windows 10 pro, 64bit

@PleahMaCaka
Copy link

😭

@dwhenson
Copy link

😢

@kud
Copy link

kud commented Jan 3, 2023

+1 also having issues. I apply monkey patch and then VS Code won't open after a restart. This is a monkey patch to hide the top bar.

Solution for now is to re-install the Mac app (download & overwrite .app file) and just not run the monkey patch.

I confirm.

@ryanberckmans
Copy link

ryanberckmans commented Jan 16, 2023

I use monkey-patch to hide the UI's top bar. I've done so for years and can't go back to the spammy top bar. I guess this means I'm on vsc 1.73 until there's a workaround/fix or vsc itself lets you hide the top bar.

@esonec
Copy link

esonec commented Jan 21, 2023

I use monkey patch to customize fonts and font sizes for VSCode Explorer, Outline, Terminal.
And also for other customization features. I will have to stay with 1.73 unless Monkey patch will be re-enabled in future versions of VSCode. I encourage MS to re-enable Monkey patch.

@trvswgnr
Copy link

I doubt Microsoft will update the official VSCode to fix the breaking changes from microsoft/vscode#166126.

The good news is VSCodium has removed the mangling to specifically resolve issues like these. Now Monkey Patch just needs to do some upkeep and support it.

See VSCodium/vscodium#1390 (comment).

@daiyam
Copy link

daiyam commented Jan 31, 2023

(VSCodium's main maintainer here)
Some users are indicating that the current git version is working. So the extension might just need to be published on OpenVSX (I use https://github.com/HaaLeo/publish-vscode-extension)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests