fix: update bootstrap-amd for recent upstream changes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2022
|
Thanks. I'll do my best to test this tomorrow. |
|
@knopp would love to see this fixed so we can start working with a patched VSCodium! |
|
When will the fix be merged? |
ziishaned
approved these changes
Jan 18, 2023
|
I have switched to VSCodium 1.74+ (now I'm using VSCodium 1.76.1), where a modified version of MonkeyPatch works (with Custom UI!). ☞ VSCodium/vscodium#1390 (comment) MonkeyPatch + CustomUI is essential! Please keep it guys~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes:
microsoft/vscode#161161
microsoft/vscode#166686
This partly fixes #56, #34, #55, and #59 such that the UI should still appear after monkey-patch is installed.
Fixing customize-ui and other downstream monkey-patching extensions will require a patch in VSCodium for now (Which I did a proof of concept at VSCodium/vscodium@master...forivall:vscodium:monkey-patch , which allows customize-ui to work) and further down the line, some cooperation with VSCode's core team, or reverse-source mapping to access private / protected methods.