[blockindex] simplify indexer height checking #4466
Conversation
dustinxie
requested review from
CoderZhi,
Liuhaai,
envestcc and
a team
as code owners
dustinxie
force-pushed
the
heightcheck
branch
from
3e90a65 to
f9346d5
Compare
|
| } | ||
| } | ||
| for i := startHeight; i <= targetHeight; i++ { | ||
| for i := tipHeight + 1; i <= targetHeight; i++ { |
There was a problem hiding this comment.
currently tipHeight at L52 returns 0, so we need extra code (L78-84) to check every indexer's start height, which is somewhat confusing, since the same code (to check every indexer's start height) also appears in SyncIndexer. So that should be handled by SyncIndexer, and we only need to get it's height (at L52)
| if h < s.config.ContractDeployHeight { | ||
| h = s.config.ContractDeployHeight | ||
| } | ||
| return h, nil |
There was a problem hiding this comment.
combine the concept of start height into Height(). It is used by PutBlock() to check if the incoming block should be put/handled, so simply return the max of height and startHeight -- if the incoming block's height is smaller, nothing needs to be done
Description
as title, see comments in the PR.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: