[api] Re-send pending actions #4498
Open
+236
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
force-pushed
the
action-retry
branch
from
45f7028 to
96d9585
Compare
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
envestcc
force-pushed
the
action-retry
branch
from
02684d8 to
acb48b7
Compare
|
dustinxie
reviewed
Dec 5, 2024
| // ActionRadio broadcasts actions to the network | ||
| type ActionRadio struct { | ||
| broadcastHandler BroadcastOutbound | ||
| messageBatcher *batch.Manager | ||
| chainID uint32 | ||
| unconfirmedActs map[hash.Hash256]*radioAction | ||
| mutex sync.Mutex |
There was a problem hiding this comment.
use ThreadSafeLRU to hold unconfirmedActs, then we can remove the mutex?
dustinxie
reviewed
Dec 5, 2024
| } | ||
| } | ||
| }() | ||
| } |
There was a problem hiding this comment.
if we are able to remove the mutex, this can be replaced by existing RecurringTask?
dustinxie
reviewed
Dec 5, 2024
| @@ -62,6 +108,58 @@ func (ar *ActionRadio) Stop() error { | |||
|
|
|||
| // OnAdded broadcasts the action to the network | |||
| func (ar *ActionRadio) OnAdded(selp *action.SealedEnvelope) { | |||
| ar.mutex.Lock() | |||
| defer ar.mutex.Unlock() | |||
There was a problem hiding this comment.
see comments about removing mutex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an action resend mechanism to prevent a transaction from being stuck due to unsuccessful broadcasting.
Pre PR: #4497
Need further discussion:
How to avoid or alleviate network congestion when dealing with a large number of transactions? Feel free to show your mind
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: