Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boxo in place of archived ipfs repos #118

Closed
wants to merge 2 commits into from
Closed

Conversation

gammazero
Copy link

No description provided.

Copy link

welcome bot commented Aug 7, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@aschmahmann
Copy link

aschmahmann commented Aug 8, 2024

I think realistically this should be closed. AFAICT the only reason this repo exists and is not archived is because @rvagg doesn't like boxo (e.g. see comments like ipld/frisbii#129 (comment) and other github issues) and because he wants this one line in go-car to exist while not depending on boxo https://github.com/ipld/go-car/blob/4398919824543108f188688e924d6d68e6722b25/car.go#L62. As a result adding in a boxo dependency likely seems like a no-go for the maintainer(s) here (although ofc he/they might disagree).


Aside: IMO that line (along with the similar ones for go-ipld-prime selectors) could be removed from the go-car package lieu of traversals happening in other libraries (similar to the ideas expressed in ipld/go-car#416) which would make this repo go away entirely, however my understanding is that approach was rejected and this repo still stands mostly to serve that one line. If I'm mistaken here and we can make this repo archivable that'd be nice.

@gammazero
Copy link
Author

Closing per above comment.

@gammazero gammazero closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants